emacs-eask / cli

CLI for building, running, testing, and managing your Emacs Lisp dependencies
https://emacs-eask.github.io/
GNU General Public License v3.0
138 stars 21 forks source link

Fix: match behavior of declare linter to checkdoc #272

Closed joshbax189 closed 4 weeks ago

joshbax189 commented 4 weeks ago

Fixes #271

Summary

After the change:

> ~/git/eask-cli/bin/eask lint declare --strict
`js-comint.el` with check-declare
js-comint.el:148:Warning (check-declare): said ‘nvm--find-exact-version-for’ was defined in .eask/31.0.50/elpa/nvm-20240921.1901/nvm.el: arglist mismatch

`test-js-comint.el` with check-declare
No issues found

(Total of 2 files have checked)

The output line is formatted like an error and the exit code is 1.

Questions

Perhaps 'Warning (check-declare)' should be removed from the output? e.g. this seems like a better message

js-comint.el:148: ‘nvm--find-exact-version-for’ was defined in .eask/31.0.50/elpa/nvm-20240921.1901/nvm.el: arglist mismatch
jcs090218 commented 4 weeks ago

Thank you for taking care of this! Merged!🥳