search

emacs-eldev / eldev

Elisp development tool
https://emacs-eldev.github.io/eldev/
GNU General Public License v3.0
227 stars 17 forks source link

Use a more reliable method to test for an empty parameter #39

Closed juergenhoetzel closed 3 years ago

juergenhoetzel commented 3 years ago

Fixes invalid test condition and also strips outer set of quotes.

Sadly the previous commit 2fe82850cd73d6c7e88a8192d41060f5af865586 was defective.

Reference: https://stackoverflow.com/questions/2541767/what-is-the-proper-way-to-test-if-a-parameter-is-empty-in-a-batch-file

BTW: Thanks for the new MELPA release: Seting up eldev using setup-eldev-emacs works on all major platforms: https://github.com/juergenhoetzel/github-eldev-test/actions/runs/785613998

doublep commented 3 years ago

BTW: Thanks for the new MELPA release: Seting up eldev using setup-eldev-emacs works on all major platforms

As far as I can see, MELPA Stable still provides 0.8.1, though maybe your test works, since webinstall parts are naturally from 0.9.