search

emacs-eldev / eldev

Elisp development tool
https://emacs-eldev.github.io/eldev/
GNU General Public License v3.0
229 stars 17 forks source link

Fix argument parsing issue for Windows github web-installer #47

Closed juergenhoetzel closed 3 years ago

juergenhoetzel commented 3 years ago

Command line arguments %[1-9] do not exist when piping to CMD.

This is a follow up for https://github.com/doublep/eldev/pull/41 where we missed to fix the issue also for the github webinstaller.

doublep commented 3 years ago

It looks a bit strange that the file is completely replaced according to the diff. Was it really meant to be like that?

doublep commented 3 years ago

The failure is not in your patch, it's already in master. Not sure if you received notification from commit 62648d3. But this is on Windows only either way, so would be nice if you looked into it.

juergenhoetzel commented 3 years ago

The failure is not in your patch, it's already in master. Not sure if you received notification from commit 62648d3. But this is on Windows only either way, so would be nice if you looked into it.

I will take a look.

juergenhoetzel commented 3 years ago

It looks a bit strange that the file is completely replaced according to the diff. Was it really meant to be like that?

Yes I have consolidated the two webinstall scripts (the github version did also still use CRLF line endings). I should have mentioned this in the commit message: I will amend the commit message.

doublep commented 3 years ago

Thank you, merging.