search

emacs-eldev / eldev

Elisp development tool
https://emacs-eldev.github.io/eldev/
GNU General Public License v3.0
226 stars 17 forks source link

Switch to MSYS2 for installing Emacs on MS-Windows in CI (fix for #55) #56

Closed ikappaki closed 2 years ago

ikappaki commented 2 years ago

Hi,

could you please consider fix for #55 whereby the Emacs MS-Windows precompiled binaries installed with purcell/setup-emacs@master GitHub action used in Eldev CI, ships with a GnuTLS version which is susceptible to a bug with expired issuer certificates.

The solution proposed here is to install Emacs as an msys2 package. msys2 itself is already preinstalled on the GitHub Windows 2019 servers, we just utilize it to install the latest Emacs package and set up the global PATH to point to it with an additional GitHub action.

Once a new binary is available in purcell/setup-emacs, we can switch back to that installer. The benefit of purcell/setup-emacs over msys2 is that you can specify which version to install, while with msys2 you can only download the latest available precompiled version (which can change without notice, i.e. going from 27.2 to 28.5 once that becomes available), i.e. no fine grain control which exact version/binary is being used.

All test pass now on CI.

Thanks

doublep commented 2 years ago

@ikappaki: Hello. Now that Emacs 28.1 is out, can we revert to using purcell/setup-emacs also for Windows? Or are there other problems?

ikappaki commented 2 years ago

@ikappaki: Hello. Now that Emacs 28.1 is out, can we revert to using purcell/setup-emacs also for Windows? Or are there other problems?

Hi @doublep, yes we can revert, submitted #69 for it. (it is cs090218/setup-emacs-windows we revert to, not purcell/setup-emacs, I had made a mistake in the comments). thanks