emacs-eldev / eldev

Elisp development tool
https://emacs-eldev.github.io/eldev/
GNU General Public License v3.0
226 stars 17 forks source link

webinstall/github-eldev.bat fails to install Eldev properly #70

Closed ikappaki closed 2 years ago

ikappaki commented 2 years ago

Hi,

The webinstall/github-eldev.bat fails to work as a GitHub workflow, although the eldev.bat is successfully installed, it fails to publish the location it is installed at.

To reproduce, create a github workflow file, that installs and runs eldev.bat on MS-Windows:

name: CI

on: [push, pull_request]

jobs:
  test:
    runs-on: ${{matrix.os}}

    strategy:
      matrix:
        os: [windows-latest]
        emacs_version: [ '28.1']

    steps:
    - name: Set up Emacs on Windows
      uses: jcs090218/setup-emacs-windows@master
      with:
        version: ${{matrix.emacs_version}}

    - name: Install Eldev on MS-Windows
      run: |
        curl.exe -fsSL https://raw.github.com/doublep/eldev/master/webinstall/github-eldev.bat | cmd /Q

    - name: Check out the source code
      uses: actions/checkout@v2

    - name: Test the action worked.
      run: |
        eldev help

It fails with:

...

2s
Run curl.exe -fsSL https://raw.github.com/doublep/eldev/master/webinstall/github-eldev.bat | cmd /Q
Microsoft Windows [Version 10.0.20348.707]
(c) Microsoft Corporation. All rights reserved.

D:\a\eldev\eldev>
10s
2m 7s
Run eldev help
eldev: D:\a\_temp\66bfe8f7-dc7c-4248-87dc-f22aaa1afcc2.ps1:2
Line |
   2 |  eldev help
     |  ~~~~~
     | The term 'eldev' is not recognized as a name of a cmdlet, function, script file, or executable
     | program. Check the spelling of the name, or if a path was included, verify that the path is correct
     | and try again.

Error: Process completed with exit code 1.
...

Although the tool is installed, it is not in the PATH. Not sure if this has ever worked before. PR to follow.