emacs-eldev / eldev

Elisp development tool
https://emacs-eldev.github.io/eldev/
GNU General Public License v3.0
226 stars 17 forks source link

Emacs 28.1 "Error: Symbol’s function definition is void: nil" #74

Closed Silex closed 2 years ago

Silex commented 2 years ago

Hello,

Emacs 28.1 fails byte compilation at https://github.com/Silex/docker.el/actions/runs/2574037279

It's hard to tell exactly what fails because I added Emacs 28.1 to our tests and the test immediatly failed, while all the other versions passed, but in https://github.com/Silex/docker.el/pull/205 we seem to think it's eldev.

doublep commented 2 years ago

Thank you for the report, it is indeed a bug in Eldev (1.1.2). Trigerred by warnings in recursively byte-compiled files, i.e. when one file requires another, not yet compiled one. Will be fixed in 1.1.3 in a couple of hours.

Emacs 28 issues lots of docstring warnings, that's why you see it on 28.1, but not earlier versions. If you want to silence those, add to file Eldev:

(with-eval-after-load 'bytecomp (setf byte-compile-warnings '(not docstrings)))

doublep commented 2 years ago

I don't know what gets broken with Emacs snapshot, cannot reproduce locally using your images:

$ docker image ls
REPOSITORY    TAG           IMAGE ID       CREATED         SIZE
silex/emacs   master        bb0e3ee96bed   17 hours ago    421MB
silex/emacs   latest        cfcfa7f36cbe   5 days ago      421MB

I'll ignore this for now, more important is that it now works with 28.1.

Silex commented 2 years ago

Thanks! :+1: