search

emacs-elsa / Elsa

Emacs Lisp Static Analyzer and gradual type system.
GNU General Public License v3.0
640 stars 26 forks source link

A likely typo #141

Closed xuchunyang closed 5 years ago

xuchunyang commented 5 years ago

https://github.com/emacs-elsa/Elsa/blob/65cd51c183d0ae57cd22d0b623727519c2644d87/elsa-typed-builtin.el#L128-L129

The only DEFUN in the file is (byte-code BYTESTR VECTOR MAXDEPTH).

Fuco1 commented 5 years ago

OOOOHHH :D So this is why I was getting those super-funny warnings on eq comparisons about "vector mixed"... Thanks for catching it! I was going to spend some quality time checking the eq extension which I've added some time ago.

This saved me couple hours easily :)

Fuco1 commented 5 years ago

@xuchunyang Do you want to craete a pull request? Changing the eq to the function you mentioned should be enough. You deserve your commit counter to go up! :D

xuchunyang commented 5 years ago

I've created a pull request.