emacs-elsa / Elsa

Emacs Lisp Static Analyzer and gradual type system.
GNU General Public License v3.0
640 stars 26 forks source link

test: Replace Emake test with Eask #190

Closed jcs090218 closed 1 year ago

jcs090218 commented 1 year ago

I want to rely on Eask entirely, so I have done the following:

  1. Replace commands cask [COMMAND] to eask [COMMAND] from .github/workflows/test.yml
  2. Replace Emake tests with Eask in Makefile

After this, we can remove anything from Emake and Cask. But now I have left everything as it is since Cask has more users than Eask.

Additional changes:

  1. Add tests on macOS and Windows.
  2. Add complete tests including (package, install, compile)
  3. Add Eask-file

What can be improved in the future?

  1. Add package-lint to our test cycle via eask lint package
  2. Add checkdoc to our test cycle via eask lint checkdoc
Fuco1 commented 1 year ago

I think we can remove the makefile entirely. It was there because of the travis-ci setup which I actually deleted yesterday. I don't find any utility in calling some make targets instead of eask/cask directly.

I would still keep at least the Cask file to support both Cask and Eask.

Unrelated, but one thing that currently stops me from using Eask for development is that if I do eask link elsa <elsa directory> in elsa package itself, it will run into an infinite loop resolving the symlink. Cask somehow prevents this.

jcs090218 commented 1 year ago

I think we can remove the makefile entirely. It was there because of the travis-ci setup which I actually deleted yesterday. I don't find any utility in calling some make targets instead of eask/cask directly.

Done. 👍

I would still keep at least the Cask file to support both Cask and Eask.

Sounds good to me! That's reasonable. :)

I mentioned it only because we can, but we don't have to.

Unrelated, but one thing that currently stops me from using Eask for development is that if I do eask link elsa in elsa package itself, it will run into an infinite loop resolving the symlink. Cask somehow prevents this.

Does it stop entirely? Anyways, the command is a bit different from Cask. It should be eask link add elsa <elsa directory>. I've opened another PR in #192 to fix the README .

Fuco1 commented 1 year ago

This is what I mean with the linking: notice how I link to the same directory (elsa project) where I then run eask exec elsa

image

jcs090218 commented 1 year ago

This is what I mean with the linking: notice how I link to the same directory (elsa project) where I then run eask exec elsa

Ah, okay. I'm on it.

jcs090218 commented 1 year ago

@Fuco1 Can you test this branch and see if it works? https://github.com/emacs-eask/cli/tree/fix/dd-recursive

Edit: I have merged into master branch, therefore, you can test it by pulling the latest commit.

Fuco1 commented 1 year ago

Yea, now it works :)

Fuco1 commented 1 year ago

LGTM :+1: