search

emacs-ess / ESS

Emacs Speaks Statistics: ESS
https://ess.r-project.org/
GNU General Public License v3.0
613 stars 160 forks source link

ess-toggle-underscore #1251

Open r2evans opened 1 year ago

r2evans commented 1 year ago

It seems that the intent of 3b5d903b306b1c8fb211ac7c17c59e71eb2bcd01 is to remove the simplicity of (ess-toggle-underscore nil).

  1. Documentation still suggests its availability, https://github.com/emacs-ess/ESS/blob/5c4ae91cefa5c56fd13b204a9a996825af836a67/doc/onewfeat.texi#L1434
  2. Is there a new way to do this? I think it's no longer required, I upgraded and a single _ did as expected.

Perhaps this is just an issue to update that texi file.

lionel- commented 1 year ago

It seems that the intent of https://github.com/emacs-ess/ESS/commit/3b5d903b306b1c8fb211ac7c17c59e71eb2bcd01 is to remove the simplicity of (ess-toggle-underscore nil).

From the commit message the intent was to solve some compilation warnings.

Documentation still suggests its availability,

This is not the documentation but the changelog for ESS 5.2.0. I can't find the release date for this version but looks like it's from 2004 or older.

a single _ did as expected.

What do you mean by expected?

Perhaps this is just an issue to update that texi file.

It might need a mention in the current release changelog. Or it might need to be aliased to something else, not sure why the alias was dangling.

r2evans commented 1 year ago

I recall (years ago) setting that so that hitting _ alone did not impose the <- assignment. Frankly, that's an old setting I just haven't cleaned my lisp in a while. This isn't a failing bug report, just a notice that required I remove the (apparently unnecessary) reference to it. Thanks @lionel- !