emacs-ess / ESS

Emacs Speaks Statistics: ESS
https://ess.r-project.org/
GNU General Public License v3.0
623 stars 162 forks source link

Question about sed options in Makefile #1292

Closed plantarum closed 6 months ago

plantarum commented 6 months ago

I just checked out the latest commit and tried to make it, and got hung up at this line:

https://github.com/emacs-ess/ESS/blob/d941b25f10716c307f546bdd9cb85d4ac5c1cf38/Makefile#L25

This fails with the following output:

make
********************* VERSIONS **************************
GNU Emacs 30.0.50
ESS 24.01.1
ESSR 1.8
sed: -e expression #1, char 1: unknown command: `.'

This is on Ubuntu 20.04. Deleting the string .orig fixes the problem.

The online documentation at:

Thanks for any assistance!

mmaechler commented 6 months ago

Indeed, there should not be any space between -i and .orig ... ... that change is very recent (April 24). I've now fixed it, in e49c85f9