search

emacs-ess / ess-stata-mode

4 stars 5 forks source link

obsolete font-lock-reference-face in ess-stata-lang.el #11

Open djh1202 opened 1 year ago

djh1202 commented 1 year ago

I had trouble rendering font colors in .do files.

Turns out the problem was ess-stata-lang.el, which defines font-lock-reference-face, which has been marked obsolete for awhile. When I replaced font-lock-reference-face with font-lock-constant-face, things started working again.

rsparapa commented 1 year ago

Huh? I don't even see a file named ess-stata-lang.el

BrendanHalpin commented 1 year ago

It's there: ess-stata-mode is separate from core ESS, but hasn't changed often. In fact, I feel like the only user, so Hi, djh1201!

rsparapa commented 1 year ago

Which directory? I must have screwed my git!

BrendanHalpin commented 1 year ago

My local setup is non-standard, but you'll see it in the "Code" tab on this page, alongside ess-stata-mode.el

djh1202 commented 1 year ago

It's there: ess-stata-mode is separate from core ESS, but hasn't changed often. In fact, I feel like the only user, so Hi, djh1201!

Hi! Yes I use it quite a lot, so thanks for all your work over the years!

rsparapa commented 1 year ago

Oh, I forgot that it had moved. Doh

roblem commented 11 months ago

When I replaced font-lock-reference-face with font-lock-constant-face, things started working again.

I can confirm that doing this fixes fontification bugs in orgmode src blocks when using emacs-jupyter and the nbstata kernel.