search

emacs-ess / ess-stata-mode

4 stars 5 forks source link

inferior-ess-prompt doesn't recognise prompt in for-loops #4

Closed BrendanHalpin closed 3 years ago

BrendanHalpin commented 3 years ago

inferior-ess-prompt doesn't work in for-loops, where the prompt takes this form:

forvalues x=1/2 {
  2.

Changing ess-stata-mode.el from

(inferior-ess-prompt           . "\\([.:>] \\|--more--\\)")

to 

(inferior-ess-prompt           .  "\\( *[0-9]*[.:>] \\|--more--\\)")

resolves the problem (but I haven't tested much for unintended consequences).

vspinu commented 3 years ago

Thanks @BrendanHalpin for all the issues. Unfortunately AFAIK none of the ESS developers is using stata and can systematically develop for it. If you can provide PRs for all of your issues we would be more than happy to merge.

BrendanHalpin commented 3 years ago

I'll do that.

Is it better to do one pull request per issue, or to pool them (the resolved ones at least)?

lionel- commented 3 years ago

One per issue please. PRs should be small and have only one concern.

BrendanHalpin commented 3 years ago

OK. Do I need some sort of write-access to the repository?

lionel- commented 3 years ago

You're good to go, anyone can submit a pull request. It will be reviewed and merged by someone with commit access.

BrendanHalpin commented 3 years ago

Closed by #7