search

emacs-ess / ess-stata-mode

4 stars 5 forks source link

Change inferior-ess-prompt to deal with for loops #7

Closed BrendanHalpin closed 3 years ago

BrendanHalpin commented 3 years ago

Inside a for-loop the Stata prompt changes like this:

. forvalues x = 1/5  {
  2. di `x'
  3. }
}

A small change to inferior-ess-prompt accommodates this

lionel- commented 3 years ago

Thanks! Can you also add bullet items for your past and current contributions in doc/newfeat.texi please?

lionel- commented 3 years ago

Can you also add bullet items for your past and current contributions in doc/newfeat.texi please?

oops now I see we're not in the ESS repo. Perhaps add a simple text NEWS file so we keep track of changes?

BrendanHalpin commented 3 years ago

I should be able to do this in the next few days

lionel- commented 3 years ago

Let's merge this right away until then.

By the way you can address our reviews by pushing new commits to the pull request (just push to your remote branch from which the PR was created). You should generally not open a new PR unless you've rewritten everything or taken a new approach.