Modes that need to be merged

[jojojames]

https://github.com/jojojames/evil-integrations/issues/1#issuecomment-341984606

ansi-term / term
help
package-menu
profiler

@Ambrevar I think I added the ones from my end, what's left are modes that probably won't go in (like org and the packages that would probably require some merging.)

Like a nice intermediary step is for me to push ^ those above packages and you can just modify it as you like after?

[Ambrevar]

Like a nice intermediary step is for me to push ^ those above packages and you can just modify it as you like after?

What's the "^"?

Yes, add yours first, I'll to the merge and add the rest of my stuff tomorrow.

[jojojames]

^ was just those 4 modes in the list.

I've added what I needed to. You can do your thing @Ambrevar 🥇

[Ambrevar]

Note to myself: Add

• debbugs
• elfeed
• emms
• helm
• image+
• pdftools
• transmission
• ztree

[Ambrevar]

I've completed the merge.

I've kept my version of help, package-menu, and profiler since it uses hand-written bindings that are more consistent with the rationale.

Regarding term / ansi-term: I've renamed it to "term", I think it translates better that this targets all term-based modes. I've integrate your idea of not going back when switching to normal mode.

[jojojames]

Awesome. We can close this one then.

[jojojames]

@Ambrevar For evil-term, not sure if you had mentioned this before, but the insert maps didn't seem to work for me.

C-a, C-b, tab, etc. I'll add back in the insert maps I had for the time being.

[Ambrevar]

Hmm, you shouldn't have. I made sure this worked when I merged, but if it does not for you, then my test was flawed. We should not need those keys anyways. I'll work on a proper fix.

[Ambrevar]

You are right, it was broken, but I'm not sure I understand what's happening precisely. In my case C-f and C-b would work as expected. Can you confirm?

I'll see about it tomorrow.

[jojojames]

What do you expect those to do by the way?

I expect those C-* keys to work similar to a regular terminal in insert state.

I.e. C-b should move back a character in the terminal.

[Ambrevar]

Sorry, my phrasing was confusing. Yes of course I'm expecting C-* keys to do what they ought: be passed to the underlying shell. In most cases, your shell would understand these bindings Emacs-style.

In my case, C-f and C-b do work properly, while most other bindings don't, instead some unprintable character is inserted. I'd like to understand why.

[Ambrevar]

OK, got it: Evil has some C- prefixed bindings in insert mode, that's why only some C- bindings were shadowed. You are right, we need the override those keys, except for C-c and C-h I'd say. I'll push a change as soon as possible.

[Ambrevar]

Fixed: 9c263e5.