search

emacs-evil / evil-collection

A set of keybindings for evil-mode
GNU General Public License v3.0
1.22k stars 272 forks source link

Magit help menu fails to open with recent versions of transient #831

Open ItsHoff opened 2 months ago

ItsHoff commented 2 months ago

Steps:

  1. Enable evil-collection Magit integration
  2. Open magit-status
  3. Press ? to open the help menu

Result: Transient fails with transient-setup: Wrong type argument: command, (keymap (76 . magit-log) (74 . magit-display-repository-buffer) (106 . magit-status-jump) (73 . magit-init) (105 . magit-gitignore) (72 . magit-describe-section) (104 . magit-info) (70 . magit-pull) (102 . magit-fetch) ...), command

The issue does not reproduce when evil-collection integration is disabled. I bisected the issue and it seems to have started with https://github.com/magit/transient/commit/c356d1bca13ef1dd78ec7e83a89936cc58553f75.

condy0919 commented 2 months ago

I'm using Emacs master (transient 0.7.4 is bundled), can't reproduce this issue.

YasserKa commented 2 months ago

I have this issue as well with transient 0.7.4 magit 4.0.0

Could be reproduced by (evil-collection-magit-want-horizontal-movement t)