search

emacs-evil / evil

The extensible vi layer for Emacs.
GNU General Public License v3.0
3.38k stars 281 forks source link

evil-visual-restore highlighting is broken in visual block mode #1109

Open diamond-lizard opened 5 years ago

diamond-lizard commented 5 years ago

Issue type

Environment

Emacs version: GNU Emacs 26.1 (build 1, x86_64-pc-linux-gnu) of 2018-10-09 Operating System: Gentoo Linux Evil version: evil-git-99bcf8c Evil installation type: manual Graphical/Terminal: terminal Tested in a make emacs session (see CONTRIBUTING.md): Yes

Reproduction steps

1 - Start Emacs with make emacs 2 - Type: 3k 3 - Type: <C-v> (that's control-v) 4 - Type: 3e 5 - Type: <C-v> 6 - Type: M-x evil-visual-restore

Expected behavior

I expect to see the text ;; This buffer (the same text selected in steps 3 and 4) highlighted in yellow

Actual behavior

No highlighting is shown

Further notes

Though highlighting is not shown, the text is actually selected, as you can verify by typing yp or moving point.

Upon further testing, it seems the highlighting does show, but only after 5 seconds have passed. I had expected the highlighting to show instantly.

TheBB commented 5 years ago

I can reproduce this in both block and line mode, but not char mode, but only if I specifically type M-x evil-visual-restore. Just gv works fine.