Fix Visual Insert affecting one too many lines

emacs-evil / evil

The extensible vi layer for Emacs.

GNU General Public License v3.0

3.35k stars 283 forks source link

Fix Visual Insert affecting one too many lines #1889

Closed axelf4 closed 5 months ago

axelf4 commented 5 months ago

This fixes a regression caused by commit 004ac4e0cd766d49d48d53270e9c0c080ad9f173, where Visual mode "I" repeated the insertion on one too many lines unless at EOB.

Hi-Angel commented 4 days ago

@axelf4 is it just me (being a devel-version Emacs user), or does this commit result in failure to byte-compile Evil?

Upgrade to recent evil from MELPA only compiles part of Evil files, but compiling evil-commands.el fails. Here's a snippet from make compile when run on latest Evil code:

evil-commands.el:2644:2: Error: List contains a loop: (lower-right lower-left upper-left upper-right lower-right lower-left upper-left upper-right lower-right lower-left . #6)