Make exwm-randr-mode use a separate X connection

emacs-exwm / exwm

Emacs X Window Manager

https://elpa.gnu.org/packages/exwm.html

GNU General Public License v3.0

278 stars 14 forks source link

Make exwm-randr-mode use a separate X connection #55

Closed Stebalien closed 5 months ago

Stebalien commented 5 months ago

And make enabling it idempotent (part of #47).

exwm-randr.el (exwm-randr--connection): create a separate connection variable for EXWM randr, following up from this 1 GitHub discussion. (*): switch to the new variable. (exwm-randr--assert-connected): a new function to assert that randr is enabled & connected (for interactive commands). (exwm-randr-refresh): use the aformentioned function. (exwm-randr-mode, exwm-randr-enable): move these to the top so we can reference the mode variable.

Stebalien commented 5 months ago

Note: I think this code is correct, but I can't test it on a multi-monitor setup until Saturday evening.

medranocalvo commented 5 months ago

I had a read and looks OK. I can't test either.

I wonder whether exwm-randr is more an utility module or integral to EXWM. Especially if we move in the direction of #8. (Still have to participate over there... some day.)h

Thank you.

Stebalien commented 5 months ago

Yeah, you're right. But I think we should cross that line if/when we address #8.

Stebalien commented 5 months ago

I've confirmed that it works.