search

emacs-exwm / exwm

Emacs X Window Manager
https://elpa.gnu.org/packages/exwm.html
GNU General Public License v3.0
284 stars 14 forks source link

Fix on-Notify #71

Closed mgi closed 4 months ago

mgi commented 4 months ago

I don't know if it has ever worked (unless there was a change in `cl-case' semantic).

minad commented 4 months ago

We have several uses of cl-case in the code base. Maybe we should replace all of them with pcase?

mgi commented 4 months ago

I don't know… maybe. But for this case, a simple cond does the trick.

mgi commented 4 months ago

I forgot to say that this patch fixes a regression for me: I'm switching back and forth between the laptop screen and an external one with calls to xrandr scripts. Without this patch, EXWM does not adapt its resolution when switching (it was on 0.30).

Stebalien commented 4 months ago

All the other cl-case instances look correct (they're matching on symbols).

Stebalien commented 4 months ago

(let's merge this one as-is because it's fixing a bug, we can replace everything with pcases in a separate patch if desirable)

mgi commented 4 months ago

Steven Allen @.***> writes:

Merged #71 into master.

Thanks Steven. -- Manuel Giraud