search

emacs-exwm / xelb

X protocol Emacs Lisp Binding
https://elpa.gnu.org/packages/xelb.html
GNU General Public License v3.0
26 stars 4 forks source link

Replace deprecated lsh with ash #20

Closed minad closed 7 months ago

minad commented 7 months ago 
Replace deprecated `lsh' with `ash'

The functions differ in their behavior for right shifts (negative argument
COUNT) for negative values. The replaced calls are either left shifts or pass a
positive value; as such they are not affected.

* xcb-types.el: (xcb:-pack-*): `lsh' to `ash'. Argument positive (unsigned).
  (xcb:-unpack-*): `lsh' to `ash'. Left shifts.
  (xcb:-f*-to-binary*, xcb:-binary*-to-f*): `lsh' to `ash'. Argument positive.
* xelb-gen (xelb-parse-bit): `lsh' to `ash'. Left shift.
  (xelb-parse-op): `lsh' to `ash'. Left shift.
* xcb-keysyms.el: (xcb:keysyms:-update-modkeys): `lsh' to `ash'. Left shift.
  (xcb:keysyms:keycode->keysym): `lsh' to `ash'. Arguments modifiers and
  group-info positive?

Fixes #1

minad commented 7 months ago

@Stebalien Do you think it is safe enough to merge this? I run it locally, so far without issues.

Stebalien commented 7 months ago

Eh, probably. If you didn't see any immediate issues, I doubt any more testing will help.

Stebalien commented 7 months ago

(and it'll be nice to get rid of all the warnings)

minad commented 7 months ago

Okay, thanks. Let's go then.