search

emacs-gnuplot / gnuplot

A major mode for Emacs for interacting with Gnuplot
GNU General Public License v3.0
137 stars 21 forks source link

Drop XEmacs support #50

Closed mtreca closed 3 years ago

mtreca commented 4 years ago

I don't know what you think about this @conao3 but dropping support for XEmacs (and older version of Emacs, but I will open a separate issue for this) could simplify the code quite a bit by removing a lot of workarounds and hack.

More specifically, the comment string of gnuplot-toolbar-use-toolbar states that the gnuplot tool bar does not work on GNU Emacs. Can anyone confirm this? If this is the case, should we aim at porting the toolbar features to GNU Emacs or just drop them altogether?

mtreca commented 4 years ago

Similarly, looking at the codebase, I think this package should drop support for gnuplot < 4.0, which was released in 2004. It would simplify some edge cases for gnuplot 3.7.

mtreca commented 4 years ago

I did not know that @bruceravel was still active on this project, so paging him for is opinion, especially regarding the toolbar!

conao3 commented 4 years ago

We can drop support for XEmacs, I think too. It also makes sense to support Emacs-24.4 or later, considering that the user can download it from MELPA using package.el.

But before we do any large refactoring, we should create tests and set up CIs.

mtreca commented 4 years ago

@conao3 I agree. There are a number of compilation warnings we should take care of too.

mtreca commented 3 years ago

Closed with #59