emacs-gnuplot / gnuplot

A major mode for Emacs for interacting with Gnuplot
GNU General Public License v3.0
138 stars 21 forks source link

Fix failing CI checks for GNU Emacs 25 #69

Closed mtreca closed 3 years ago

mtreca commented 3 years ago

CI checks for GNU Emacs 25 keep failing.

@conao3 is there anything we can do to fix these?

conao3 commented 3 years ago

Yes it is my fault but I cannot understand why.

mtreca commented 3 years ago

No worries, I will try to look into it today.

I replaced the Cask call with the native make test in my fork (see here) and I have contrasting results:

Should we push those changes and maybe remove the Cask setup until we write some proper tests for the package? Next step would be to make the Github CI runner recognize failing ERT tests (we will have to fix them later on, I opened an issue about it in #70).

mtreca commented 3 years ago

Fixed in 1dd661e