emacs-grammarly / flycheck-grammarly

Grammarly support for Flycheck
GNU General Public License v3.0
127 stars 8 forks source link

Support gfm-mode #12

Open yupyvovarov opened 3 years ago

yupyvovarov commented 3 years ago

While markdown-mode is supported, GitHub Flavored Markdown (gfm-mode) doesn't.

jcs090218 commented 3 years ago

You can set variable flycheck-grammarly-active-modes to '(gfm-mode). The default value is '(text-mode latex-mode org-mode markdown-mode).

yupyvovarov commented 3 years ago

You can set variable flycheck-grammarly-active-modes to '(gfm-mode). The default value is '(text-mode latex-mode org-mode markdown-mode).

It's the first what I did

flycheck-grammarly-active-modes is a variable defined in ‘flycheck-grammarly.el’.
Its value is (gfm-mode text-mode latex-mode org-mode markdown-mode)
Original value was 
(text-mode latex-mode org-mode markdown-mode)

But the check still doesn't work:

Syntax checker in buffer README.md in gfm-mode:

  grammarly
    - major mode: `gfm-mode' not supported
    - may enable: yes

Flycheck cannot use this syntax checker for this buffer.

Flycheck Mode is enabled.  Use C-u C-c ! x to enable disabled
checkers.
jcs090218 commented 1 year ago

Sorry for the late reply.

Does it give you any error? Sorry I don't use gfm-mode. 😅

ajax-pyvovarov-y commented 1 year ago

@jcs090218 Nope, any errors.

feng-li commented 7 months ago

@yupyvovarov You could try to add the mode to custom-set-variables like

'(flycheck-languagetool-active-modes
   '(text-mode latex-mode LaTeX-mode org-mode markdown-mode gfm-mode message-mode))

or using the :custom key to config it with use-package

(use-package flycheck-grammarly
  :custom
  (flycheck-grammarly-active-modes
   '(text-mode latex-mode LaTeX-mode org-mode markdown-mode gfm-mode message-mode))
  :config
  ...
  )