search

emacs-helm / helm-descbinds

A helm frontend for describe-bindings.
GNU General Public License v3.0
116 stars 12 forks source link

Unusual matching behaviour #23

Closed cruegge closed 8 years ago

cruegge commented 8 years ago

Matching in helm-descbinds is unusual for helm plugins in that the input string is not split into words which are then matched individually. Only regexps work.

I do not really understand the way helm's API works, but for me, redefining helm-descbinds-source to use helm-build-sync-source instead of just returning an alist fixed the problem. Here's my redefinition:

(defun helm-descbinds-source (name candidates)
  (append (helm-build-sync-source name
            :candidates candidates)
          helm-descbinds-source-template))
thierryvolpiatto commented 8 years ago

Christoph Ruegge notifications@github.com writes:

Matching in helm-descbinds is unusual for helm plugins in that the input string is not split into words which are then matched individually. Only regexps work.

I do not really understand the way helm's API works, but for me, redefining helm-descbinds-source to use helm-build-sync-source instead of just returning an alist fixed the problem. Here's my redefinition:

(defun helm-descbinds-source (name candidates) (append (helm-build-sync-source name :candidates candidates) helm-descbinds-source-template))

Your fix is right, could you provide a PR?

Thanks.

Thierry