search

emacs-helm / helm-dictionary

Helm source for looking up dictionaries
31 stars 12 forks source link

Use cl-lib #16

Closed thierryvolpiatto closed 10 years ago

thierryvolpiatto commented 10 years ago

Please use cl-lib. Now helm is using cl-lib. Thanks.

tmalsburg commented 10 years ago

The recommendation always was to do

(eval-when-compile (require 'cl))

but I see that all other helm sources do

(require 'cl-lib)

So I will just follow the other sources and do the latter (without eval-when-compile).

tmalsburg commented 10 years ago

See 9a3ef7233bf34987259b3c6ac4b213696b54df92.

michael-heerdegen commented 10 years ago

Yes, in contrast to cl it is officially allowed to require cl-lib at run-time. That allows you to use cl functions at run-time. For cl, you could only use its macros, because they get expanded when compiling.

The price was that now all stuff in cl-lib has a cl-... prefix.

michael-heerdegen commented 10 years ago

The price was that now all stuff in cl-lib has a cl-... prefix.

That's what we still must do: add the cl- prefix (e.g. "loop" -> "cl-loop"). When you compile the file in emacs -Q (use helm.sh) you should see byte compiler warnings about the according functions.

tmalsburg commented 10 years ago

Arg, fixed here: 4672ead8090f19498ef0e0f03de7051c96757857 Thanks for catching that.