search

emacs-helm / helm-dictionary

Helm source for looking up dictionaries
31 stars 12 forks source link

Divers improvements #23

Closed thierryvolpiatto closed 8 years ago

tmalsburg commented 8 years ago

Thank you very much, Thierry! But could you please reintroduce the following two lines:

if (or (string-match helm-pattern l1term)
       (string-match helm-pattern l2term))

They are really needed (see here). Without them we will see plenty of entries in which neither the language matches the search term. My very comprehensive German/English dictionary is not usable without these lines. Thank you!

thierryvolpiatto commented 8 years ago

Titus von der Malsburg notifications@github.com writes:

Thank you very much, Thierry! But could you please reintroduce the following two lines:

if (or (string-match helm-pattern l1term) (string-match helm-pattern l2term))

They are really needed (see here). Without them we will see plenty of entries in which neither the language matches the search term. My very comprehensive German/English dictionary is not usable without these lines.

Sorry forgot about this.

Thierry

tmalsburg commented 8 years ago

Merged, thanks again!