search

emacs-helm / helm-dictionary

Helm source for looking up dictionaries
31 stars 12 forks source link

wrong usage of helm-browse-url #8

Closed thierryvolpiatto closed 10 years ago

thierryvolpiatto commented 10 years ago

You misunderstand what helm-browse-url does, you should use:

         (let ((browse-url-browser-function
                (or helm-dictionary-browser-function
                    browse-url-browser-function)))
           (helm-browse-url (format cand (url-hexify-string helm-pattern)))))))

and remove the helm-browse-url entry in helm-dictionary-browser-function.

tmalsburg commented 10 years ago

Actually, I believe I understood it :) but I wanted to give the user an easy way to get exactly the behavior of browse-url. helm-browse-url is different from browse-url, because it tries a different list of browsers than browse-url-default-browser in case that broswse-url-browser-function is undefined. Anyway, I'll trust your wisdom and make the change you suggest. See 8ab7cfb309a5b229fec41e6682d2942c092331cd.