emacs-helm / helm-org

53 stars 9 forks source link

helm-org-insert-link-to-heading-at-marker now supports ID properties #26

Closed rodrigomorales1 closed 1 year ago

rodrigomorales1 commented 3 years ago

Solves #25 and is a shorter rewriting of #23.

This have been accomplished by rewriting the function in order for it to use org-store-link and org-insert-last-stored-link. Thus, the user is able to decide whether headlines must be referenced through their IDs (by setting org-id-link-to-org-use-id to t) or through their names.

When submitting a pull request, please include the following information:

Note that Emacs and Org versions persist "in the wild" for some time after release, so it is not appropriate to only test with the latest released or development versions of Org; tests must include versions still commonly in use. Proposed changes must not break functionality for existing users.

alphapapa commented 3 years ago

@rdrg109 Please look carefully at the code you have removed. You appear to have omitted some important parts that set the buffer. I don't think the code you wrote will work correctly in all cases.