search

emacs-helm / helm-system-packages

A Helm interface to the package manager of your operating system
GNU General Public License v3.0
106 stars 11 forks source link

Add support for macOS brew #16

Closed tuedachu closed 6 years ago

tuedachu commented 6 years ago

First version of 'helm-system-package' for home brew

Working functionalities:

TODO: (1) Implement show-dependencies' function (2) Show packages explicitly installed (functionhelm-system-packages-brew-list-explicit' already exists) (3) Implement `find-files' (4) Keymap

Ambrevar commented 6 years ago

Thank you very much for this contribution!

Before we can proceed, please rebase your pull request onto upstream master and make sure only significant commits present. While it's good practice to make commits atomic, it's OK if the -brew.el file is provided through only one commit since the file is new. That is to say, unless some commits are particularly relevant (pitfalls, exceptions, special cases, etc.). Use your better judgment.

piotr-yuxuan commented 6 years ago

I've tried to helped for the review process by addressing your most simple remarks, however I'm unsure about where I should put these changes to be helpful. I've opened PR https://github.com/tuedachu/helm-system-packages/pull/1 to @tuedachu's PR, is it a good pattern? is there anything simpler? Also, I commented this PR to make clear which remarks of yours are still to be addressed and which ones should be fixed now. Just tell me if you consider it's useless noise or if it can smoothen your review process!

tuedachu commented 6 years ago

@piotr-yuxuan, Thanks for your contribution. I have been quite busy for the last weeks, and I did not have time to review @Ambrevar 's comments. I wil try to work on it tomorrow (to make it compatible with the current version of 'helm-system-packages'). I am planning to make a new PR by the end of this week.

Note that many functionalities are still missing, so your contribution can be very useful. I am not a very experienced user of brew, I just covered the basic functionalities (instal, uninstal, linkapp, show information).

piotr-yuxuan commented 6 years ago

If I have time, I'll try to look into this.

Ambrevar commented 6 years ago

I've just pushed initial support for Guix. Since it is slightly different from the other package managers, you might find it interesting to study.

tuedachu commented 6 years ago

@Ambrevar , I finalized the first version of helm-system-packages for macOS brew. Basic functionalities work fine. Any comment is of course very welcome.

@piotr-yuxuan , Please feel free to contribute. I will sell my mac soon, so I won't be able to continue developing this software.

Ambrevar commented 6 years ago

Thank you very much for your work!