search

emacs-helm / helm-system-packages

A Helm interface to the package manager of your operating system
GNU General Public License v3.0
106 stars 11 forks source link

Prototype for dnf support #26

Closed DamienCassou closed 6 years ago

DamienCassou commented 6 years ago

2018-09-19-115653_740x539_scrot 2018-09-19-115729_4480x1080_scrot

DamienCassou commented 6 years ago

This is early stage. No action is available, only listing. Can you please give me a minimal list of things I have to implement before you can merge this PR?

Ambrevar commented 6 years ago

Before I merge this, could you please implement the information display at least? Let me know if you need help with that.

Ambrevar commented 6 years ago

By the way, your screenshot does not shot alignment, but your code seems to do it. Is alignment working? And there is no : separator either, right?

Ambrevar commented 6 years ago

Forgot one thing: Feel free to update the readme to mention the new dnf support!

DamienCassou commented 6 years ago

Before I merge this, could you please implement the information display at least? Let me know if you need help with that.

done. Please see screenshot above.

By the way, your screenshot does not shot alignment, but your code seems to do it. Is alignment working? And there is no : separator either, right?

I implemented alignment after I took the screenshot. I've updated the screenshot.

Forgot one thing: Feel free to update the readme to mention the new dnf support!

done

Ambrevar commented 6 years ago

The screenshot seems to be the same as before :p

Ambrevar commented 6 years ago

Merged, thank you very much for your awesome contribution!

Keep going, at least install and uninstall would be very welcome :)

DamienCassou commented 6 years ago

The screenshot seems to be the same as before :p

sorry, I forgot to save the change :-). Now it's good.

Ambrevar commented 6 years ago

Looks great, thanks!