Open Thaodan opened 1 week ago
Björn Bidar @.***> writes:
What happened?
I noticed I'm getting strange Void function nil errors when trying to use completion in Magit.
After investigating it is because helm-completion-in-region-default-sort-fn is set to nil by magit in magit-completing-read-multiple. The core issue is very similar to magit/magit#4437.
The change that broke Magit's way of overriding the default sort in region function is 432f01f I think.
Yes, should be fixed now, please confirm.
Thanks!
Now to the core of this issue: How should one override or disable helm-completion-in-region-default-sort-fn when it's executed without prior check?
My bad, now we check!
-- Thierry
Björn Bidar @.***> writes:
What happened?
I noticed I'm getting strange Void function nil errors when trying to use completion in Magit.
After investigating it is because helm-completion-in-region-default-sort-fn is set to nil by magit in magit-completing-read-multiple. The core issue is very similar to magit/magit#4437.
The change that broke Magit's way of overriding the default sort in region function is 432f01f I think.
Yes, should be fixed now, please confirm. It does work now, thanks.
Thanks!
Now to the core of this issue: How should one override or disable helm-completion-in-region-default-sort-fn when it's executed without prior check?
My bad, now we check!
Should the custom value for helm-completion-in-region-default-sort-fn also contain nil as potential value if this is the intended way to disable sorting? Similarly the commit explicitly mentions magit if this is explicitly supported then mentioning it sounds off to me as it's not just magit that could not want to use the sorting function.
Björn Bidar @.***> writes:
Björn Bidar @.***> writes:
What happened?
I noticed I'm getting strange Void function nil errors when trying to use completion in Magit.
After investigating it is because helm-completion-in-region-default-sort-fn is set to nil by magit in magit-completing-read-multiple. The core issue is very similar to magit/magit#4437.
The change that broke Magit's way of overriding the default sort in region function is 432f01f I think.
Yes, should be fixed now, please confirm. It does work now, thanks.
Thanks!
Now to the core of this issue: How should one override or disable helm-completion-in-region-default-sort-fn when it's executed without prior check?
My bad, now we check!
Should the custom value for helm-completion-in-region-default-sort-fn also contain nil as potential value if this is the intended way to disable sorting?
Initially it was not the intention, but now, as we are checking for it, it is a potential correct value.
Similarly the commit explicitly mentions magit if this is explicitly supported then mentioning it sounds off to me as it's not just magit that could not want to use the sorting function.
Yes, it is just a reminder for myself to retrieve later what the issue was.
— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.*Message ID: @.***>
-- Thierry
Björn Bidar @.***> writes:
Yes, should be fixed now, please confirm. It does work now, thanks.
Great, thanks.
-- Thierry
What happened?
I noticed I'm getting strange
Void function nil
errors when trying to use completion in Magit.After investigating it is because
helm-completion-in-region-default-sort-fn
is set to nil by magit inmagit-completing-read-multiple
. The core issue is very similar to magit/magit#4437.The change that broke Magit's way of overriding the default sort in region function is 432f01f39d6372c26134d1cc7ad4946f71466675 I think.
Now to the core of this issue: How should one override or disable
helm-completion-in-region-default-sort-fn
when it's executed without prior check? I know there's the option to just set the function toidentity
but is this the right approach? Without digging deeper the error from the plainfuncall
call is kinda meaningless.How to reproduce?
magit-log
Helm Version
Master branch
Emacs Version
Emacs-25*
OS
GNU/Linux
Relevant backtrace (if possible)
No response
Minimal configuration