Closed jcs090218 closed 2 years ago
I noticed flymake-languagetool--disabled-rules
and flymake-languagetool--spelling-rules
variables are now opened to public. Maybe we should rename it to single dash -
instead of two? (single dash for public vars, two for private vars)
Might want to use defcustom
instead of defvar
for flymake-languagetool--spelling-rules
variable as well.
cc @tpeacock19
I agree with the defcustoms and public naming conventions. Do you want to make that change and we can merge this PR, or should I create a separate?
You can merge this PR, or create another PR to overwrite this one. Either ways would work! :)
Also, have you had a chance to try the corrections? if you have any suggestions or feedback, I would appreciate. I would love to have a standard flymake correction interface/package. But, I imagine there are not too many that provide corrections/suggestions.
I think this is a cool idea! 😁 I haven't tried it yet but LGTM by looking at the code.
I think there is a warning in the compile log: