search

emacs-languagetool / flymake-languagetool

Flymake support for LanguageTool
GNU General Public License v3.0
33 stars 11 forks source link

Don't rely on `flymake` internals. Fix compatibility with edge Emacs #16

Closed Lysander6 closed 10 months ago

Lysander6 commented 10 months ago

flymake bundled with the edge/master branch version of Emacs no longer provides the flymake--overlays function^1, which breaks the core functionality of this package.

Even though overlays are now available via flymake--really-all-overlays (as seen in the linked commit), I thought it was best to stick to the public API functions. I don't really know elisp, so hopefully my assumption that functions with -- in their name are internal (i.e. not part of the public API) is correct.

I haven't tested these changes on versions of Emacs other than the one I use, so I don't mind if this fix doesn't end up upstream.

tpeacock19 commented 10 months ago

Yes, it looks good to me. Thank you, @Lysander6.