search

emacs-languagetool / flymake-languagetool

Flymake support for LanguageTool
GNU General Public License v3.0
33 stars 11 forks source link

EoL diagnostics not working properly #19

Closed fabcontigiani closed 6 months ago

fabcontigiani commented 7 months ago

The ability to show end-of-line diagnostics is a relatively new feature introduced in flymake last year.

When enabling this feature along with flymake-languagetool, the diagnostics seem to be inserted into the text buffer instead of being displayed as in other use cases. I don't know if this is a limitation of text-mode or something unrelated to this package.

Original buffer: image

After M-x flymake-mode: image

Expected behavior: image

Emacs version: 29.2 flymake version: 1.3.7 LanguageTool version: 6.3

Relevant configuration used in screenshots:

;;; init.el
(use-package flymake
  :hook prog-mode
  :custom
  (flymake-show-diagnostics-at-end-of-line 'short)
  (flymake-no-changes-timeout 1.5))

(use-package flymake-languagetool
  :hook ((text-mode latex-mode org-mode markdown-mode) . flymake-languagetool-load)
  :custom
  (flymake-languagetool-server-jar "/home/fab/LanguageTool-6.3/languagetool-server.jar"))
tpeacock19 commented 6 months ago

Thanks for the note, I actually was not aware of this feature. It should be fixed with the most recent commit 8c7f97e5dc831bfefe847a19ef034da5a8d41244. I'm planning to implement some customizations surrounding the levels, but currently they all show up as "warnings".

Please let me know if this is working for you.

fabcontigiani commented 6 months ago

It's working perfectly now, thank you so much! ^^