search

emacs-languagetool / flymake-languagetool

Flymake support for LanguageTool
GNU General Public License v3.0
33 stars 11 forks source link

implement incremental checking based on built-in sentence navigation #24

Open tpeacock19 opened 6 months ago

tpeacock19 commented 6 months ago

This allows us to send only partial chunks of text to the server instead of sending the entire buffer for each modification to the buffer.

tpeacock19 commented 6 months ago

@jcs090218 I think this is finally in a good place for a real review. Whenever you have time can you take a look and try it out? There are still many areas I wish to refactor/optimize; however, it'll be better to get more eyes on it.

tpeacock19 commented 6 months ago

@jcs090218 Is there any way to get the Windows-latest snapshot test to actually run? I have seen that it always fails at the eask clean all command.

jcs090218 commented 6 months ago

No, unfortunately. For more info, see https://github.com/emacs-eask/cli/issues/224.

tpeacock19 commented 5 months ago

@jcs090218 I was going to merge this PR, but I'm not certain why all the macOS tests are failing - there is not much information in logs. Whenever you have time, can you take a look?

jcs090218 commented 5 months ago

I've re-run the test. It looks good now! ;)