search

emacs-languagetool / flymake-languagetool

Flymake support for LanguageTool
GNU General Public License v3.0
33 stars 11 forks source link

http server feature #4

Closed tpeacock19 closed 2 years ago

tpeacock19 commented 2 years ago

I've made an attempt at addressing #2, using an HTTP server rather than the commandline. It has worked for me and I figured I would share in case it would be useful for others.

jcs090218 commented 2 years ago

Awesome! 👍

Can you update our README file as well? And it seems like there is a compile error, see the following:

In toplevel form:
flymake-languagetool.el:165:1:Error: Unused lexical variable ‘objects’
make: *** [Makefile:19: unix-compile] Error 1
tpeacock19 commented 2 years ago

I've updated to README to include an example using LanguageTool's remote api as well. Let me know if it makes sense or I need to update anything else further.

jcs090218 commented 2 years ago

You might want to forward declare the variable url-http-end-of-headers to resolve the latest CI.

In toplevel form:
flymake-languagetool.el:181:14:Error: reference to free variable ‘url-http-end-of-headers’
make: *** [Makefile:19: unix-compile] Error 1
tpeacock19 commented 2 years ago

I wasn't actually sure how to address that error. I think i've got it now though.

jcs090218 commented 2 years ago

Thanks! :)

jcs090218 commented 2 years ago

I think you have made decent amount of changes. Wonder if you would like to join the org and take some control of this package (to co-maintain)? Furthermore, feel free to open another to add yourself as an author if you like to (top of the file).

@tpeacock19 WDYT?

tpeacock19 commented 2 years ago

Yeah I would be happy to join. It'd be my first org so I'm not familiar with the process, but just let me know what I need to do.

jcs090218 commented 2 years ago

Great! Just sent you the invitation!

No worries! That's why it's great to have people co-maintain open source projects. :)