search

emacs-love / weblorg

Static Site Generator for Emacs
https://emacs.love/weblorg
GNU General Public License v3.0
279 stars 21 forks source link

Updated weblorg--parse-org-keyword to split filetags into collection #50

Closed AblatedSprocket closed 3 years ago

AblatedSprocket commented 3 years ago

updated weblorg--parse-org-keyword to parse filetags as collection of strings for templates. When testing, I noticed it somehow changed how names for the HTML files were generated. I don't have the test built out yet, still trying to understand how to build an argument to pass in to weblorg--parse-org-keyword (my elisp is not great).

clarete commented 3 years ago

Thank you @AblatedSprocket for putting this together! This is quite exciting 🎉

On the CI errors, it seems like they're happening even without your changes for me. I'm going to take a look at it but that shouldn't really be a blocker for this change.

Thanks again and sorry for taking a while to look at it, I haven't had enough time to work on weblorg lately but I'm catching up 😄

clarete commented 3 years ago

Well, that's awesome! I tried your code with that little change, but I most likely just reran the tests with old bytecode. It now does seem to work as expected! That's pretty awesome. Thank you for taking the time for putting this PR together, @AblatedSprocket 🙇🏾 🚀