search

emacs-lsp / dap-mode

Emacs :heart: Debug Adapter Protocol
https://emacs-lsp.github.io/dap-mode
GNU General Public License v3.0
1.29k stars 181 forks source link

enhancement req: sticky stack frame with peek #195

Open rileyrg opened 4 years ago

rileyrg commented 4 years ago

While learning/debugging this particular code framework I find I use the stack frame a lot. I would like to suggest the following enhancements/tweaks.

1) "As is" it would be nice if the stack frame remembered the last line selected. As it is one has to scroll down quite a lot to the point of interest each time you bring it up.

2) more ambitious - make the stack frame sticky (option in custom) and also provide a peek facility. In helm for example right arrow would peek the buffer under point but would keep focus in the stack frame.

The new tree windows are a great improvement though the facility to resize the locals pane would be great.

yyoncho commented 4 years ago

Point 2 is relatively easy to be implemented by creating helm extension which I think automatically will support the peek(persistent action). I do not understand point 1 - when you select a stackframe it should point to the correct line. Or you are talking about the sessions view?

rileyrg commented 4 years ago

When you hit return on the nth element in the stack frame it closes and you go to that debug point. When you sf (hydra) again the stack frame cursor is at the top again. I'd like to it be where I left it. Hopefully that's a little clearer.

On Sun, 19 Jan 2020, 12:13 Ivan Yonchovski notifications@github.com wrote:

Point 2 is relatively easy to be implemented by creating helm extension which I think automatically will support the peek(persistent action). I do not understand point 1 - when you select a stackframe it should point to the correct line. Or you are talking about the sessions view?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/emacs-lsp/dap-mode/issues/195?email_source=notifications&email_token=AACYTCYWS6FIOW3LW3HG3WDQ6QYU7A5CNFSM4KIYNAXKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJKPQ3A#issuecomment-575993964, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACYTCYMWXGOPAWVTGEZXMTQ6QYU7ANCNFSM4KIYNAXA .

yyoncho commented 4 years ago

I got it. Since it has relatively low impact, I am not planning to work on this anytime soon, but if you want to give it a try here it is a guide on creating helm interfaces - https://tuhdo.github.io/helm-intro.html .This guide + existing dap-mode functions will be sufficient for you if you want to implement the feature by yourself.

rileyrg commented 4 years ago

I might well try in the near future. God knows I need to improve my elisp.

On Sun, 19 Jan 2020 at 15:45, Ivan Yonchovski notifications@github.com wrote:

I got it. Since it has relatively low impact, I am not planning to work on this anytime soon, but if you want to give it a try here it is a guide on creating helm interfaces - https://tuhdo.github.io/helm-intro.html .This guide + existing dap-mode functions will be helpful for you if you want to implement the feature by yourself.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/emacs-lsp/dap-mode/issues/195?email_source=notifications&email_token=AACYTCZ7HVRY25CAWDYC77DQ6RRSLA5CNFSM4KIYNAXKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJKT4CY#issuecomment-576011787, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACYTCY2ZZWGUBDJ3ZXYO5DQ6RRSLANCNFSM4KIYNAXA .

nbfalcon commented 3 years ago

Ivy supports peeking - ivy-call-and-recenter, bound to C-SPC in DOOM. Versions of dap-switch-stack-frame would have to be written for helm and ivy.