search

emacs-lsp / dap-mode

Emacs :heart: Debug Adapter Protocol
https://emacs-lsp.github.io/dap-mode
GNU General Public License v3.0
1.3k stars 181 forks source link

Don't change posframe-mouse-banish #380

Open nigredo-tori opened 4 years ago

nigredo-tori commented 4 years ago

posframe-mouse-banish is a posframe hack to get around a mouse/focus bug. It is customized globally by the user. So we probably shouldn't tie it to whether dap-mode shows its controls.

https://github.com/emacs-lsp/dap-mode/blob/5b009460b5a41c7966cc3884441c93cbaea35773/dap-ui.el#L556

https://github.com/emacs-lsp/dap-mode/blob/5b009460b5a41c7966cc3884441c93cbaea35773/dap-ui.el#L564

yyoncho commented 4 years ago

If this is not set to nil each time you click on a button it will move the cursor in the left corner of the monitor which makes the controls useless...

nbfalcon commented 4 years ago

Perhaps related to #338?

ville-h commented 3 years ago

Why is dap-mode calling (setq posframe-mouse-banish t) in case I've set (dap-ui-controls-mode 0) and explicitly called (setq posframe-mouse-banish nil)?