search

emacs-lsp / emacs

Mirror of GNU Emacs
http://www.gnu.org/software/emacs/
GNU General Public License v3.0
72 stars 8 forks source link

Crash after `lsp-workspace-restart` #1

Closed ericdallo closed 1 year ago

ericdallo commented 1 year ago

After running lsp-workspace-restart it seem emacs crash and I only can get those logs

2022-11-11_09-44

INFO: Compiled emacs-lsp/emacs with --with-native-compilation flag on debian 11

sebastiansturm commented 1 year ago

I have also seen a few segfaults on Emacs 29 (with native compilation, on Ubuntu 22.04, with the native json-rpc patches applied). For me it always happened when trying to open files (or at least that's what I remember I've been doing at about that time). Unfortunately I don't have a backtrace; have been running it under gdb all day at work, and had it randomly open a few hundred or thousand files yesterday but no luck so far...

yyoncho commented 1 year ago

There is one issue that I am aware of. The close can be called and there might be pending write in the other thread. I have a solution for it (with the help of @606u), but I have to find the time to integrate it.

yyoncho commented 1 year ago

I pushed a patch provided by @606u . It is still not we are going to have in the end, but it will most likely improve/solve that issue.

ericdallo commented 1 year ago

I confirmed this is working with latest commit, thank you!