search

emacs-lsp / lsp-docker

Scripts and configurations to leverage lsp-mode in docker environment
GNU General Public License v3.0
241 stars 34 forks source link

Sample configuration for `lsp-docker-client-configs` is wrong. #41

Closed hotoku closed 3 years ago

hotoku commented 3 years ago

In the README.org, the following snippet is offered as sample configuration for lsp-docker-client-configs.

      (setq lsp-docker-client-configs
          '((:server-id 'bash-ls :docker-server-id 'bashls-docker :server-command "bash-language-server start")
            (:server-id 'clangd :docker-server-id 'clangd-docker :server-command "clangd")
            (:server-id 'css-ls :docker-server-id 'cssls-docker :server-command "css-languageserver --stdio")
            (:server-id 'dockerfile-ls :docker-server-id 'dockerfilels-docker :server-command "docker-langserver --stdio")
            (:server-id 'gopls :docker-server-id 'gopls-docker :server-command "gopls")
            (:server-id 'html-ls :docker-server-id 'htmls-docker :server-command "html-languageserver --stdio")
            (:server-id 'pyls :docker-server-id 'pyls-docker :server-command "pyls")
            (:server-id 'ts-ls :docker-server-id 'tsls-docker :server-command "typescript-language-server --stdio")))

In this code, quote ' is duplicated. I think it should be as following

      (setq lsp-docker-client-configs
          '((:server-id bash-ls :docker-server-id bashls-docker :server-command "bash-language-server start")
            (:server-id clangd :docker-server-id clangd-docker :server-command "clangd")
            (:server-id css-ls :docker-server-id cssls-docker :server-command "css-languageserver --stdio")
            (:server-id dockerfile-ls :docker-server-id dockerfilels-docker :server-command "docker-langserver --stdio")
            (:server-id gopls :docker-server-id gopls-docker :server-command "gopls")
            (:server-id html-ls :docker-server-id htmls-docker :server-command "html-languageserver --stdio")
            (:server-id pyls :docker-server-id pyls-docker :server-command "pyls")
            (:server-id ts-ls :docker-server-id tsls-docker :server-command "typescript-language-server --stdio")))

Note the changes like :server-id 'bash-ls -> :server-id bash-ls and :docker-server-id 'bashls-docker -> :docker-server-id bashls-docker, and so on.