search

emacs-lsp / lsp-docker

Scripts and configurations to leverage lsp-mode in docker environment
GNU General Public License v3.0
241 stars 34 forks source link

Read container-name from lsp-docker.yml both for image and container … #58

Closed korenhe closed 1 year ago

korenhe commented 1 year ago

…type

For image type, the container-name is nil and makes the name of repeated creation of container conflicts with each other.

factyy commented 1 year ago

@korenhe , sorry for the late reply! What about not reading names for images (containers created from them are meant to be only temporary, this is the whole point of using this server type) but randomizing them? As far as I remember there was a function used for adding random suffixes to container names. Maybe integrate it somehow? As for the container names we can just use random strings (as I wrote above the containers are temporary and are deleted when the server stops).

factyy commented 1 year ago

@korenhe , please take a look at this PR: #70 . It basically enables generation of container names (unique, using a global suffix) under the hood thus avoiding container name clashes.

I will probably close this particular PR in the near future. Thanks for your input!

factyy commented 1 year ago

Closing this PR as the underlying issue is now fixed by another PR