Add multi-server feature

emacs-lsp / lsp-docker

Scripts and configurations to leverage lsp-mode in docker environment

GNU General Public License v3.0

241 stars 34 forks source link

Add multi-server feature #85

Closed sfavazza closed 4 months ago

sfavazza commented 6 months ago

High level summary of changes:

add support for multiple language-servers (LS)
share path mappings among LS
use variables instead of explicit strings as JSON keys
improve concerned functions documentation
update README
add few files for quick manual testing

factyy commented 6 months ago

@sfavazza , I will take a look in a few days, a bit busy right now :)

sfavazza commented 6 months ago

The feature is there it won't go anywhere 😊

factyy commented 5 months ago

@sfavazza , I finally managed to get a bit of time to review all changes. First of all I have to say that you've done a wonderful work with not only functional changes but refactoring as well!

As for the changes everything looks good, I think you can merge this PR (but fix this small typo first though :)

@yyoncho , sorry to bother, could you please take a look at these changes? I don't feel comfortable reviewing this amount while not being a elisp guru myself :)

sfavazza commented 5 months ago

@factyy thank you for dedicating the time to this review, really appreciated. Please observe that I don't have the necessary rights to merge, so let's wait for the feedback of @yyoncho and then you guys can merge (if everything is proper).

Unless you already did it, I strongly suggest to try these changes also on your machine via the simple setup suggested in the test/README.md file.

factyy commented 4 months ago

Managed to test it briefly, everything looks fine, thanks @sfavazza