search

emacs-lsp / lsp-haskell

lsp-mode :heart: haskell
https://emacs-lsp.github.io/lsp-haskell
GNU General Public License v3.0
227 stars 56 forks source link

Disabling completion snippets does not work (anymore) #126

Closed hpdeifel closed 2 years ago

hpdeifel commented 3 years ago

Setting lsp-haskell-completion-snippets-on to nil (and restarting the server) has no effect when using the latest haskell-language-server (1.2.0).

This is probably caused by https://github.com/haskell/haskell-language-server/pull/1619 which was introduced in 1.1.0 and changed the setting name from haskell.completionSnippetsOn to the intuitively named haskell.plugin.ghcide-completions.config.snippetsOn.

Doing

(lsp-register-custom-settings
  '(("haskell.plugin.ghcide-completions.config.snippetsOn" lsp-haskell-completion-snippets-on t)))

worked for me to fix it.

michaelpj commented 3 years ago

Thanks, good point, we need to regenerate all these things to make them match the new config options.

Of course, that will break old HLSs, but I don't think we can realistically keep compatibility, especially given the pace of change right now. Caveat emptor!

michaelpj commented 2 years ago

Fixed, finally.