emacs-lsp / lsp-haskell

lsp-mode :heart: haskell
https://emacs-lsp.github.io/lsp-haskell
GNU General Public License v3.0
227 stars 56 forks source link

Add support for haskell-tng-mode #147

Closed LaurenceWarne closed 2 years ago

LaurenceWarne commented 2 years ago

Hi! This PR adds support for haskell-tng-mode. It does this by removing the hard requirement on haskell-mode and adding haskell-tng-mode to the list of modes when registering the client.

haskell-mode is currently used only in (AFAICS - I've been running it locally without haskell-mode with no issues):

Thanks, let me know what you think.

michaelpj commented 2 years ago

This looks fine to me. I suggest just getting rid of lsp-haskell--get-root, it's just redundant. I'd be tempted to bin lsp-haskell--session-cabal-dir - we have a few of these not-really-lsp-related utility functions that IMO don't really belong here.

LaurenceWarne commented 2 years ago

This looks fine to me. I suggest just getting rid of lsp-haskell--get-root, it's just redundant. I'd be tempted to bin lsp-haskell--session-cabal-dir - we have a few of these not-really-lsp-related utility functions that IMO don't really belong here.

Cool, if that's ok, I've removed both of them in the last commit.

michaelpj commented 2 years ago

Thanks!