Closed LaurenceWarne closed 2 years ago
This looks fine to me. I suggest just getting rid of lsp-haskell--get-root
, it's just redundant. I'd be tempted to bin lsp-haskell--session-cabal-dir
- we have a few of these not-really-lsp-related utility functions that IMO don't really belong here.
This looks fine to me. I suggest just getting rid of
lsp-haskell--get-root
, it's just redundant. I'd be tempted to binlsp-haskell--session-cabal-dir
- we have a few of these not-really-lsp-related utility functions that IMO don't really belong here.
Cool, if that's ok, I've removed both of them in the last commit.
Thanks!
Hi! This PR adds support for
haskell-tng-mode
. It does this by removing the hard requirement onhaskell-mode
and addinghaskell-tng-mode
to the list of modes when registering the client.haskell-mode
is currently used only in (AFAICS - I've been running it locally withouthaskell-mode
with no issues):lsp-haskell--get-root
-> change: aliased tolsp--suggest-project-root
lsp-haskell--session-cabal-dir
-> change: first check ifhaskell-cabal-find-file
is bound and fall back tolsp--suggest-project-root
if necessaryThanks, let me know what you think.