search

emacs-lsp / lsp-haskell

lsp-mode :heart: haskell
https://emacs-lsp.github.io/lsp-haskell
GNU General Public License v3.0
227 stars 56 forks source link

Depend on haskell-mode #164

Closed glyn closed 1 year ago

glyn commented 1 year ago

Note to reviewers: this PR is untested.

Fixes https://github.com/emacs-lsp/lsp-haskell/issues/163

glyn commented 1 year ago

CI failed: 2022-12-30-184407_905x749_scrot

There seems to be a duplicate dependency on haskell-mode. Not sure what is causing this.

glyn commented 1 year ago

@jcs090218 Please would you approve the workflow so we can see if CI is fixed? Also, kindly PTAL at my other comments in this PR.

jcs090218 commented 1 year ago

Please would you approve the workflow so we can see if CI is fixed?

I don't have permission to this repo; let me ping repo owners. They should be able to help us!

cc @yyoncho @alanz

glyn commented 1 year ago

Looks great, thanks!

On the plus side, you're welcome. On the other hand, eek, let's hope it works!