search

emacs-lsp / lsp-haskell

lsp-mode :heart: haskell
https://emacs-lsp.github.io/lsp-haskell
GNU General Public License v3.0
236 stars 62 forks source link

Realign options with HLS `master` branch #174

Closed sir4ur0n closed 1 year ago

sir4ur0n commented 1 year ago

By following the instructions to generate the options, I found many missing options, so here is a PR to realign on HLS master branch.

:warning: Unlike what the instructions say, I had to also manually change the :group from 'lsp-haskell to 'lsp-haskell-plugins for all these options. Is this normal?

alanz commented 1 year ago

I had to manually change :group too.

michaelpj commented 1 year ago

I'm confused, why is this different to what you just got, Alan?

alanz commented 1 year ago

I think it only shows differences from what is already in the emacs image when you run it.

And it may be that I had a prior attempt at updating it loaded in my machine at the time.

I guess we should do the process with a clean config each time.

michaelpj commented 1 year ago

Generally we should not be doing this off master, but off the latest release. But I don't think any options have changed, so its probably fine.