search

emacs-lsp / lsp-haskell

lsp-mode :heart: haskell
https://emacs-lsp.github.io/lsp-haskell
GNU General Public License v3.0
227 stars 56 forks source link

Don't use the debug flag by default. #179

Closed trivialfis closed 9 months ago

trivialfis commented 9 months ago

Hi all, https://github.com/emacs-lsp/lsp-haskell/blob/c443f1536404c252dbd16cf44eb47cabdcd6c45f/lsp-haskell.el#L438 enables the debug flag by default, which causes the language server to dump log to disk and become unresponsive. I think for most of the use cases, the debug flag is unnecessary. I can help remove the flag from default if this sounds reasonable.

michaelpj commented 9 months ago

Yeah, I agree that that seems like a mistake. I think it's probably helpful to have a logfile by default, but maybe even that is too opinionated?

trivialfis commented 9 months ago

Thank you for the reply. The log file is fine.

trivialfis commented 9 months ago

I opened an oneliner fix here: https://github.com/emacs-lsp/lsp-haskell/pull/180 .