search

emacs-lsp / lsp-haskell

lsp-mode :heart: haskell
https://emacs-lsp.github.io/lsp-haskell
GNU General Public License v3.0
227 stars 56 forks source link

Fix JSON false values incorrectly being encoded as nulls in code actions #183

Closed robbert-vdh closed 3 weeks ago

robbert-vdh commented 3 weeks ago

Depends on https://github.com/emacs-lsp/lsp-mode/pull/4194 to fix https://github.com/emacs-lsp/lsp-mode/issues/4184 for HLS. This allows the code action to populate missing class members to work. Blocked on the aforementioned PR.

michaelpj commented 3 weeks ago

I'm happy to use this if you think it's the right way to go. I would be open to trying to make HLS more permissive though, as I commented here: https://github.com/emacs-lsp/lsp-mode/issues/4184#issuecomment-2160415884

robbert-vdh commented 3 weeks ago

I think, at least for now, that doing both may be the way to go. Some more elaboration in the issue: https://github.com/emacs-lsp/lsp-mode/issues/4184#issuecomment-2160567567