search

emacs-lsp / lsp-haskell

lsp-mode :heart: haskell
https://emacs-lsp.github.io/lsp-haskell
GNU General Public License v3.0
227 stars 56 forks source link

Implement 21444:eval:evalCommand #89

Closed jmorag closed 3 years ago

jmorag commented 3 years ago

Describe the bug The haskell-language-server eval feature is unsupported.

To Reproduce Attempt to evaluate the code lens appearing over -- >>> 1 + 1

in a Haskell file with a working lsp session.

Expected behavior The evaluation result should appear as a comment under the expression line

Which Language Server did you use haskell-language-server

OS NixOS

Error callstack (error "BadDependency \"GhcSessionDeps\"") LSP :: Please open an issue in lsp-mode for implementing `21444:eval:evalCommand'.

michaelpj commented 3 years ago

Hmm, this is odd. You do see a code lens? I actually don't see a code lens in Emacs, although I do see one in vscode, which is quite strange, since I don't think there's anything special about that code lens as opposed to any others.

If you do see the lens but you get that error from the server, that sounds like a server bug.

michaelpj commented 3 years ago

Ah, the former issue is something in lsp-mode about showing code lenses. If I run lsp-lens-show it shows the lens, and it works for me.

So I think this may be a server bug: can you open it upstream? I'll see if I can figure out what's going on with the showing of the code lens in the sideline.

michaelpj commented 3 years ago

Well, I figured that bit out: the eval plugin isn't configured to act as a code action at all.

michaelpj commented 3 years ago

I think there's nothing for us to do in lsp-haskell, at least.